Volume Slider feature; WebSettingsDropdown widget refactoring
Description
This pull request introduces the new volume slider feature and includes a refactoring of the WebSettingsDropdown widget for improved aesthetics.
Changes Made
- Added a
volume sliderfeature to enhance user control over audio settings. - Refactored the
WebSettingsDropdownwidget to improve aesthetics. - Updated dependencies in the
pubspec.yamlfile to stay current and leverage the latest features.
Supported Platforms
This PR ensures compatibility and functionality across the following platforms:
- Android
- iOS
- Web
Additional Notes
GitHub Actions Lint Analysis Failure
A GitHub Actions lint analysis check failed due to an outdated Dart SDK version. The current Dart SDK version is 3.0.6, while the GitHub Actions setup was using an older version (2.19.4). To ensure successful analysis, it's imperative to update the Flutter SDK version within GitHub Actions configuration.
Unnecessary Break Removal
In accordance with the Dart Team's recommendation, the break command within switch cases has been removed. This improves code readability and adheres to best practices. For more details, refer to: Dart Linter Rule - Unnecessary Breaks.
Thank you for reviewing this pull request. Your feedback and suggestions are greatly appreciated.
Hi Can you please update YouTube explode plugin as well, Thanks
Done! :dart:
I've updated the youtube_explode_dart dependencie to 2.0.1 version and http dependencie to 1.1.0 (same as youtube_explode_dart )
I did a PR on the youtube_explode_dart plugin updating all dependencies. At present, my PR submitted for the youtube_explode_dart plugin has not yet been merged into the main production branch. In order to facilitate the using of the changes introduced in my PR for youtube_explode_dart, I have taken proactive steps to integrate these updates into my pod_player plugin fork repository. To achieve this, I have created a dedicated branch named development. Within this branch, I have made the necessary adjustments to reference my updated version of the youtube_explode_dart plugin.
The fully updated branch is readily accessible for exploration and utilization. Fell free to access kindly refer to the following URL: Development branch of pod_player fork
How can i disable volume bar?
I dont see any way to disable it, can you make it configurable please using PodPlayerConfig
I dont see any way to disable it, can you make it configurable please using
PodPlayerConfig
Done!
@gauravmehta13 in fact, I hadn't implemented this option previously. It was an excellent suggestion. There is now the showVolumeBar attribute in PodPlayerConfig. Its default value is true.
you are awesome thanks
Hey @Jeferson505 This is an essential feature for pod_player Thank you for your contribution, I really appreciate your effort.
@newtaDev, I am planning to add a new feature to the plugin, and I noticed that this pull request has not been merged yet. If you believe the feature would be a valuable addition to the project, kindly consider merging it :)
@Jeferson505 i belive this is an essential feature to have, But please make the review changes and resolve the conflict. so that I can merge your PR
@newtaDev, done!
@Jeferson505 Thank you for resolving the conflict But please check the review changes
@newtaDev By I understood from the check lints failure:
The current Dart SDK version is 2.19.4. Because pod_player requires SDK version >=3.0.0 <4.0.0, version solving failed.
The Dart SDK of Github Actions it's not updated. So, I believe just you can resolve that, maybe upgrading the Github Actions Dart SDK if it's possible.
If I can help, please let me know how.
@Jeferson505
Snapshot From the PR review 1
Can you remove the volume slider in mobile view, This is It's looking odd or just enable it in full screen mode in mobile view and by default
podCtr.podPlayerConfig.showVolumeBarin mobile/mobile view should befalse
2
by default
showVolumeBarin mobile/mobile view should befalseor setshowVolumeBartofalse
3
In web: Here because of
Sliderwhen we seek videoforwardorbackwardusing keyboard arrow keys, The volume also changes, This is because of the autofocus in the slider widget:
I was talking about the review changes in this PR ☝️☝️ Check above PR review comments Not about GitHub action failure