NewsKit
NewsKit copied to clipboard
feat(902): select panel with min and max size
closes #902
What
- Background - we need different size on the panel
- What did you do - added min and max width to the select panel, that way consumers can have more control of its size
- What does the reviewers should expect
I have done:
- [ ] Written unit tests against changes
- [ ] Written functional tests against the component and/or NewsKit site
- [ ] Updated relevant documentation
I have tested manually:
- [ ] The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
- [ ] The screen reader reads and flows through the elements as expected.
- [ ] There are no new errors in the browser console coming from this PR.
- [ ] When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
- [ ] The Playground feature is working as expected
Before:
After:
Who should review this PR:
How to test:
You can preview these changes on: Documentation Site: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/902-select-panel-size Storybook: http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/902-select-panel-size/storybook