NewsKit icon indicating copy to clipboard operation
NewsKit copied to clipboard

Select component causes page jump

Open mstuartf opened this issue 1 year ago • 1 comments

Describe the bug

In some scenarios, the first time the Select is opened after the page is loaded, the scroll position jumps.

To Reproduce

Steps to reproduce the behavior: PR: https://github.com/newscorp-ghfb/NewsKit/pull/860

  1. /theme/creating-a-theme
  2. Scroll so the Select component is in view with space underneath for the panel
  3. Click the Select

Expected behavior

  • Page does not scroll OR only scrolls enough for panel to be in view

Screenshots / Video / Test Environment

  • Page scrolls to bottom

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

mstuartf avatar May 03 '23 08:05 mstuartf

Related to #825 ?

jps avatar May 09 '23 13:05 jps