NewsKit icon indicating copy to clipboard operation
NewsKit copied to clipboard

Container queries - storybook changes

Open jps opened this issue 1 year ago • 2 comments

Description

Looks like we should be able to proceed with this now as https://github.com/emotion-js/emotion/issues/2876 has been closed

Spike outcome from before: https://nidigitalsolutions.jira.com/wiki/spaces/NPP/pages/4135977048/PPDSC-2238+CSS+Container+Queries

Previous PR: https://github.com/newscorp-ghfb/NewsKit/pull/400

Docs will be updated in separate ticket

Follow the suggestion from the PR and add storybook scenario for

  • GridLayout ( handleResponsiveProp function )
  • CardComposable
  • Block
  • TextBlock
  • Hidden and Visible

Add support for new units as per the PR

How do we want to document this

Business Benefit/Value

Allow consumers to use this new capability with NewsKit

Acceptance Criteria

As a user of the design system, I should be able to use container queries

jps avatar Apr 05 '23 08:04 jps

@jps create docs ticket and add

Update docs

  • https://newskit.co.uk/theme/theming/using-a-theme/ convert to TSX page if not done already

  • Create a new documentation page in themes "Creating and using themes" called "building responsive interfaces" Move the section Breakpoint behaviour in component defaults into this new page

  • Add further section on how to use container queries to this page.

Estimated at: 3 story points

jps avatar Apr 20 '23 09:04 jps

Docs ticket created by James is: https://github.com/newscorp-ghfb/NewsKit/issues/840

JohnTParsons avatar Apr 21 '23 07:04 JohnTParsons