terraform-provider-newrelic icon indicating copy to clipboard operation
terraform-provider-newrelic copied to clipboard

chore(docs): update reference for data.newrelic_entity#serving_apm_application_id

Open kohbis opened this issue 2 years ago • 2 comments

Description

Update a page for https://github.com/newrelic/terraform-provider-newrelic/pull/1018

  • Data Source
    • newrelic_entity
  • Attributes
    • serving_apm_application_id

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • [x] My commit message follows conventional commits
  • [ ] My code is formatted to Go standards
  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

No added testing as it’s document update only

kohbis avatar Oct 16 '22 02:10 kohbis

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 16 '22 02:10 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 16 '22 02:10 CLAassistant

Hi @kohbis thank you for your contribution! We follow conventional commits for the New Relic Terraform Provider. Can you re-word your commit messages to the following format? - docs: Update reference for data.newrelic_entity

mbazhlekova avatar Oct 18 '22 20:10 mbazhlekova

@mbazhlekova @NSSPKrishna Sorry...I've broken this branch 😢 I create https://github.com/newrelic/terraform-provider-newrelic/pull/2063 instead of this PR

kohbis avatar Oct 19 '22 12:10 kohbis