terraform-provider-newrelic icon indicating copy to clipboard operation
terraform-provider-newrelic copied to clipboard

Bug/Regression: Inability to filter by facet with `one_dashboard_raw`

Open RDhar opened this issue 2 years ago • 9 comments

Summary

The newly-introduced one_dashboard_raw (documentation) does not appear to support filtering by facets, which is a significant regression.

Expected Behaviour

Much like one_dashboard, it should be possible to filter by facet using the linked_entity_guids attribute, or similar alternative.

Actual Behaviour

There is no replacement or workaround. If anything, now the account ID needs to be explicitly declared which is undoes the work done in #1193 merged in #1219 for v2.19.0 to inherit the dashboard's account ID by default.

Environment

  • Terraform: v1.0.3
  • Provider: v2.24.1
  • OS: Windows 10 Pro

Thanks for your time.

RDhar avatar Aug 04 '21 16:08 RDhar

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Aug 19 '21 13:08 stale[bot]

I can understand marking this as stale due to the lack of activity. That being said, this is a significant regression of functionality preventing wider adoption of one_dashboard_raw in most capacities. Would hope this considered as a priority for complete configuration of dashboard, per #1211.

RDhar avatar Aug 19 '21 14:08 RDhar

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 09 '21 01:09 stale[bot]

This issue has been automatically closed due to a lack of activity for an extended period of time.

stale[bot] avatar Sep 16 '21 03:09 stale[bot]

Hi @kidk. Per #1211, bumping this as the lack of facet filtering is a significant regression blocking wider adoption of one_dashboard_raw.

RDhar avatar Oct 07 '21 11:10 RDhar

Hi, we also face the same issue, For now we need to activate filter with the UI but then terraform is in error!

titoko avatar Oct 11 '21 12:10 titoko

Following the release of v2.30.0, the changelog mentions the introduction of filter_current_dashboard feature to determine the linked page entity guid automatically. This is great news, many thanks for the implementation @pmillett! Would it be possible to share some documentation around usage example please, @jthurman42?

There are at least three issues (#1349, #1200, #1193) which are perfectly resolved by this feature. Could you also confirm this applies to one_dashboard_raw just as it does to one_dashboard for a consistent roll-out?

RDhar avatar Oct 14 '21 23:10 RDhar

On an existing dashboard, I removed linked_entity_guids = […] lines and replaced them with filter_current_dashboard = true. While the operation completed successfully without error, the widgets didn't have any filters.

When I re-ran terraform apply, I observed filter_current_dashboard = false -> true again, implying it was never set.

Edit: Per v2.30.1, the filter_current_dashboard = false -> true continues to exist but the widgets now have the expected filter set.

RDhar avatar Oct 16 '21 17:10 RDhar

Unfortunately, using filter_current_dashboard = true is still not possible in one_dashboard_raw and using data source to query entity for linked_entity_guids is not an option when the name of a dashboard can change. I would love to see this improvement added as it would solve a lot of issues with our dashboards.

rgembalik avatar Mar 29 '22 09:03 rgembalik