nr1-slo-r
nr1-slo-r copied to clipboard
newrelic
Defining SLO with Latency (Calculated) indicator through Entity Explorer brings up interface for alert-based Latency SLOs
Description
In SLO/R, one can define a SLO using the 'Latency (Calculated)' indicator, which uses transaction data, or with the 'Latency' indicator, which uses alerts. When selecting 'Latency (Calculated)' in the SLO/R Nerdpack, the system behaves as expected, bringing up a transaction picker. When selecting the same in entity explorer, the system brings up an alert picker instead of the transaction picker.
Steps to Reproduce
- Define SLO in Entity Explorer view
- Select indicator 'Latency (Calculated)'
- Input fields for 'Latency' appear.
Expected Behaviour
Selecting 'Latency (Calculated)' in Entity Explorer should bring up the Duration Limit and Transactions fields, not Alerts.
Relevant Logs / Console output
Your Environment
- NR1 CLI version used: n/a
- Browser name and version: Chrome 86.0.4240.111 (Official Build) (x86_64)
- Operating System and version: macOS Catalina 10.15.7 (19H2)
Additional context
This is probably a miss from my previous PR adding the 'Latency (Calculated)' indicator, I will take ownership of investigating and fixing this.
The changes to slo-r-main to add Calculated Latency were not made in slo-r-entity.
@ricegi @kpeet It looks like both main and entity components are providing similar functionality with only minor differences in implementation. Is there a compelling reason to maintain them separately, or should we consider merging them into one shared component?
@andrewseling - I fixed this in my latest fork - It does make sense to make the form a shared component - but I will leave that to @ricegi 's discretion since there are some differences in the forms (i.e - SLO Groups)
this is fixed with https://github.com/newrelic/nr1-slo-r/pull/133 - should be good to close.