newrelic-ruby-agent icon indicating copy to clipboard operation
newrelic-ruby-agent copied to clipboard

Support Rails 7.2

Open kaylareopelle opened this issue 1 year ago • 1 comments

rails/rails milestone for 7.2

estimated release June 2024

Can be accessed using 7-2-stable

kaylareopelle avatar May 21 '24 00:05 kaylareopelle

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

protolite-well-known-types

github-actions[bot] avatar May 28 '24 17:05 github-actions[bot]

Unit Test Results

   702 files   -    234     702 suites   - 234   28m 11s :stopwatch: - 5m 28s 3 662 tests  - 1 543  3 658 :heavy_check_mark:  - 1 526  4 :zzz:  - 17  0 :x: ±0  7 381 runs   - 3 090  7 373 :heavy_check_mark:  - 3 056  8 :zzz:  - 34  0 :x: ±0 

Results for commit c0ace0d8. ± Comparison against base commit 88460093.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 28 '24 18:05 github-actions[bot]

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (db42bae) to 75.99% (fffa52e) by ?.

    68 individual files with coverage change

    FilenameBase (db42bae)Merge (fffa52e)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?95.45%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?
  • firebase-database

    Overall coverage changed from 50.16% (db42bae) to 50.21% (fffa52e) by +0.04%.

    FilenameBase (db42bae)Merge (fffa52e)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-installations

    Overall coverage changed from ? (db42bae) to 58.68% (fffa52e) by ?.

    23 individual files with coverage change

    FilenameBase (db42bae)Merge (fffa52e)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?
  • firebase-messaging

    Overall coverage changed from 84.12% (db42bae) to 84.24% (fffa52e) by +0.11%.

    FilenameBase (db42bae)Merge (fffa52e)Diff
    Metadata.java36.51%41.27%+4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 83.32% (db42bae) to 83.38% (fffa52e) by +0.06%.

    FilenameBase (db42bae)Merge (fffa52e)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%
  • firebase-storage

    Overall coverage changed from 83.96% (db42bae) to 84.08% (fffa52e) by +0.12%.

    FilenameBase (db42bae)Merge (fffa52e)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.69%+0.30%

Test Logs

google-oss-bot avatar May 28 '24 18:05 google-oss-bot

buildSrc Test Results

37 tests   37 :heavy_check_mark:  1m 5s :stopwatch:   8 suites    0 :zzz:   8 files      0 :x:

Results for commit b23526d8.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 04 '24 18:06 github-actions[bot]

Hi guys, any update on this fix ?

binishmatheww avatar Oct 30 '24 06:10 binishmatheww

We've decided to stick with the 3.x branch of protolite for now (last updated in the repo in https://github.com/firebase/firebase-android-sdk/pull/6343 to 3.25.5)

@binishmatheww if you have a particular use case that's blocked by the version update, please update https://github.com/firebase/firebase-android-sdk/issues/5997 to keep the conversation centralized. Thanks!

rlazo avatar Oct 30 '24 17:10 rlazo