newrelic-ruby-agent icon indicating copy to clipboard operation
newrelic-ruby-agent copied to clipboard

CI: Upgrade to a newer version of Node for our SimpleCov action

Open kaylareopelle opened this issue 1 year ago • 7 comments

Node 16 is deprecated. Similar to #2584, we should update our SimpleCov action to, at a minimum, use Node 20, but preferably, use Node 22 or the latest version whenever this ticket is worked on.

Screenshot 2024-04-24 at 12 11 16 PM

Currently, we have a forked copy of this action living in the .github/actions directory. There may be multiple changes in our fork from the original, but one of the features is the addition of branch coverage percentages in the comments added to PRs after test runs.

We could also consider, as part of this ticket, contributing our changes to the original action or pushing up a fork of our action with our added functionality.

kaylareopelle avatar Apr 24 '24 19:04 kaylareopelle

https://new-relic.atlassian.net/browse/NR-262200

@kaylareopelle Not only simplecov-report there are other github actions as well for which similar warnings are visible. Few are in this workflow

prateeksen avatar Apr 24 '24 20:04 prateeksen

Thank you, @prateeksen! We've created issues for all the outdated actions. You can find them under https://github.com/newrelic/newrelic-ruby-agent/labels/ci%20node%20updates

kaylareopelle avatar Apr 24 '24 20:04 kaylareopelle

PR for similar work in csec-ruby-agent: https://github.com/newrelic/csec-ruby-agent/pull/78/files

kaylareopelle avatar Apr 24 '24 20:04 kaylareopelle

The above mentioned PR has incomplete changes. Please use this as well. https://github.com/newrelic/csec-ruby-agent/pull/79/files

prateeksen avatar Apr 25 '24 04:04 prateeksen

Simplecov-report-action is now archived, today. They are suggesting to use: octocov

prateeksen avatar Apr 25 '24 05:04 prateeksen

Thanks for these updates, @prateeksen!

kaylareopelle avatar Apr 25 '24 15:04 kaylareopelle

Simplecov was updated in a previous PR. https://github.com/newrelic/newrelic-ruby-agent/pull/2787/files#diff-c4f51a333bc84a9c03d3cf76e88f242bcda512b4f4d4f93fe566dc3e8a57be31L24

hannahramadan avatar Aug 08 '24 22:08 hannahramadan