newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

[Repository] Deleting quickstarts and components documentation and checks

Open jpvajda opened this issue 3 years ago • 2 comments

Relates to

JIRA: DEVEX-2231 - proposed

Background

In this PR #661 we had a change to delete a quickstart which lead us to this issue.

Currently the following deletion functionality is available.

  • the removal of a dashboard or an alert via a deletion would remove it from the quickstart.
  • the removal of an entire quickstart is not yet supported, since there's no corresponding mutation available for this operation.
  • But we can manually delete the quickstart from the DB if necessary (using old fashioned SQL).

Acceptance Criteria

  • [ ] Document the deletion process in our contributor guide to explain to contributors how deletions work.
  • [ ] Add a label to a PR that is attempting to do this: quickstart deletion
  • [ ] Any PR in which attempts to delete a quickstart's config.yml file or the entire directory would then have this labeled applied.
  • [ ] follow up with DevEx on our approach due to the lack of a deletion mutation.

jpvajda avatar Jan 04 '22 23:01 jpvajda

@jpvajda What should the check do? My first thought is that it should add a label to the pull request. I don't think a failed/succeeded check really helps this use case.

aswanson-nr avatar Jan 04 '22 23:01 aswanson-nr

@aswanson-nr that could work, I think we just need to be made aware when an entire quickstart is being deleted.

jpvajda avatar Jan 04 '22 23:01 jpvajda

Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.

github-actions[bot] avatar Apr 02 '23 01:04 github-actions[bot]

This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new one.

github-actions[bot] avatar Jul 16 '23 02:07 github-actions[bot]