newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

[Repository] add a check to ensure a quickstart directory name follows our conventions

Open jpvajda opened this issue 3 years ago • 4 comments

we had an issue where the directory name for this quickstart was set to Jumpstart - Quickstart, which is invalid as it breaks when we load the quickstarts into our service. The directory should be lowercase-hyphenated.

Acceptance Criteria

  • [ ] Add a check so we can check to make sure the directory name is set correctly to lowercase-hyphenated.

jpvajda avatar Nov 29 '21 21:11 jpvajda

Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.

github-actions[bot] avatar Feb 28 '22 01:02 github-actions[bot]

@aswanson-nr I'm curious if this is now enforced by the catalog service, and this is no longer a concern for the repo. What do you think?

jpvajda avatar Feb 28 '22 15:02 jpvajda

This would not be handled by the catalog service since the catalog service is unaware of the repo structure. This would need to be handled repo-side to enforce a particular repo structure.

jerelmiller avatar Feb 28 '22 19:02 jerelmiller

@jerelmiller Thank you!

jpvajda avatar Feb 28 '22 20:02 jpvajda

Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.

github-actions[bot] avatar Apr 10 '23 01:04 github-actions[bot]

This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new one.

github-actions[bot] avatar Jul 24 '23 01:07 github-actions[bot]