newrelic-quickstarts
newrelic-quickstarts copied to clipboard
[Repository] Add yaml validator
Summary
I've seen a handful of submissions now where invalid yaml is submitted, and many checks fail with complicated messages. If a submission touches a yaml file, we should have an upfront yaml validation check. If it passes, we do the remaining validation. If it fails, we skip the remaining validation -- they are still required, they just dont run.
This way, if a user submits invalid yaml, we see only one check fail with a clear requirement: submit valid yaml 🙈
example failure: https://github.com/newrelic/newrelic-quickstarts/runs/5696440570?check_suite_focus=true
Resources
https://github.com/nodeca/js-yaml
Acceptance Criteria
- [ ] Add yaml validation check to check yaml syntax
- [ ] return clear error message in case of invalid yaml. 🍠 🌶️
Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.
Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.
This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new one.