newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

Improve error output for schema validation workflow

Open moonlight-komorebi opened this issue 3 years ago • 4 comments

Summary

It was pointed in recent failures that the output produced when the validation workflow fails is not helpful. Here is a link to the failing workflow: example, and the error output is:

 Error: packs/mlops/algorithmia/dashboards/algorithmia.json
	 must be string
	 must match a schema in anyOf

The output isn't always this unfriendly, it just depends on the specific error that is encountered. In general, we want to improve the output so that no matter the error the output generated points you to the error location, and a potential fix.

Before we start this work, we should identify the specific failure cases that we want to test for so that we can take a more rigorous approach this time around.

Acceptance Criteria

  • [ ] TBD

moonlight-komorebi avatar Sep 15 '21 16:09 moonlight-komorebi

Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.

github-actions[bot] avatar Dec 15 '21 01:12 github-actions[bot]

@nr-kkenney do we still need to be concerned with this? I felt we did some improvement to error messages, but wasn't sure if we resolved this.

jpvajda avatar Jan 21 '22 18:01 jpvajda

@jpvajda yes / no. i think we handled a couple specific cases (like this one), but I imagine this could still crop up. Especially since we are going to switch how we validate.

But that can live in a new ticket, or a ticket can be created on a case by case basis based on what we see.

moonlight-komorebi avatar Jan 21 '22 19:01 moonlight-komorebi

Old issues will be closed after 105 days of inactivity. This issue has been quiet for 90 days and is being marked as stale. Reply here to keep this issue open.

github-actions[bot] avatar Apr 22 '22 02:04 github-actions[bot]

This issue is being closed due to inactivity. Is this a mistake? Please re-open this issue or create a new one.

github-actions[bot] avatar Apr 16 '23 01:04 github-actions[bot]