newrelic-quickstarts
newrelic-quickstarts copied to clipboard
feat: add coredns remote write quickstart and dashboard
Summary
Adding CoreDNS
quickstart dashboard for Prometheus remote write metrics.
Pre merge checklist
- [X] Did you check you NRQL syntax? - Does it work?
- [X] Did you include an InstallPlan and Documentation reference?
- [X] Are all documentation links publically accessible?
- [X] Did you check your descriptive content for voice and tone?
- [X] Did you check your descriptive content for spelling and grammar errors?
Dashboards
- [X] Does the PR contain a screenshot for each of your dashboards?
- [X] Do your screenshots show data?
Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!
Click the link(s) below to view a preview of your changes on newrelic.com/instant-observability
- coredns
- kubernetes/coredns
The PR checks have run and found the following warnings:
Warning | Filepath | Line # |
---|---|---|
"permissions" field should not be used | dashboards/coredns/coredns.json | 4 |
Reference the Contributing Docs for Dashboards for more information.
Hey @bpschmitt, There already is a CoreDNS quickstart, could we possibly just add this dashboard to that quickstart? If this is supposed to be separate, please ignore me!
Approved in the case this is for a new quickstart!
Hey @bpschmitt, There already is a CoreDNS quickstart, could we possibly just add this dashboard to that quickstart? If this is supposed to be separate, please ignore me!
Waiting for confirmation, but this will more than likely replace the existing one.
@aswanson-nr @josephgregoryii it has been confirmed that this will replace the existing CoreDNS quickstart, however, hold off on merging this as I plan to add some alerts this week.
@bpschmitt Awesome! I'm going to go ahead and move this to 'draft' while we wait for these updates. Feel free to bring it back into review once your changes are up!
Hey @bpschmitt - giving some updates on why validation is failing.
Looks like quickstarts/kubernetes/coredns
is using the coredns-dashboard
that was deleted from this PR. That seems to be where the error is coming from.
If we want this new dashboard to replace the old one, we can go ahead and replace coredns-dashboard
with coredns
in the kubernetes/coredns
config file.