newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

NR-41158-Apache Flink Quickstart.

Open pkudikyala opened this issue 2 years ago • 2 comments

Ticket URL: https://issues.newrelic.com/browse/NR-41158

Description: This PR has the new quickstart integration named "Apache Flink"

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

Pre merge checklist

  • [ ] Did you check you NRQL syntax? - Does it work?
  • [ ] Did you include an InstallPlan and Documentation reference?
  • [ ] Are all documentation links publically accessible?
  • [ ] Did you check your descriptive content for voice and tone?
  • [ ] Did you check your descriptive content for spelling and grammar errors?

Dashboards

  • [ ] Does the PR contain a screenshot for each of your dashboards?
  • [ ] Do your screenshots show data?
  • [ ] Has the sanitization script been run on each dashboard?

Alerts

  • [ ] Did you check that your alerts actually work?

Screenshots

Attach images of any visual changes, such as a dashboard here. screencapture-newrelic-instant-observability-preview-2022-10-20-10_33_28

pkudikyala avatar Oct 20 '22 05:10 pkudikyala

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

github-actions[bot] avatar Oct 20 '22 05:10 github-actions[bot]

Click the link(s) below to view a preview of your changes on newrelic.com/instant-observability

- flink

github-actions[bot] avatar Oct 20 '22 05:10 github-actions[bot]

hey @pkudikyala, I'm going to go ahead and move this into 'Draft' until the docs are ready.

Feel free to move it back into review once the docs are updated :)

josephgregoryii avatar Oct 27 '22 17:10 josephgregoryii

As you are updating the new image in "apache-flink" directory.

Please remove the flink image and path present in quickstarts directory https://github.com/newrelic/newrelic-quickstarts/blob/main/quickstarts/flink/logo.png

Here is the PR in which I have removed the flink logo https://github.com/newrelic/newrelic-quickstarts/pull/1493

pkudikyala avatar Nov 04 '22 07:11 pkudikyala