newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

NR-37615 Added a dashboard image and removed entity.guid field from queries

Open pkosanam opened this issue 2 years ago • 4 comments

Summary

Ticket URL: https://issues.newrelic.com/browse/NR-37615

Description: Added one more dashboard image of quickstart named php

A concise description of the changes being introduced. If you are submitting a PR for a new quickstart please review the pre merge checklist section to validate this PR is ready for review.

Pre merge checklist

  • [ ] Did you check you NRQL syntax? - Does it work?
  • [ ] Did you check your dashboard image quality? - Do they look good?
  • [ ] Did you check that your alerts actually work?
  • [ ] Did you include an InstallPlan and Documentation reference?
  • [ ] Did you check your descriptive content for voice, tone, spelling and grammar errors?
  • [ ] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots

Attach images of any visual changes, such as a dashboard here.

Preview

screencapture-newrelic-instant-observability-preview-2022-08-28-11_12_25

pkosanam avatar Aug 23 '22 06:08 pkosanam

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

github-actions[bot] avatar Aug 23 '22 06:08 github-actions[bot]

Click the link(s) below to view a preview of your changes on newrelic.com/instant-observability

- php/cakephp
- php/codeigniter
- php/guzzle
- php/joomla
- php/kohana
- php/laravel
- php/magento
- php/mediawiki
- php/odbc
- php/pdo
- php/php
- php/phpunit
- php/predis
- php/silex
- php/slim
- php/sqlite
- php/symfony
- php/yii

github-actions[bot] avatar Aug 23 '22 06:08 github-actions[bot]

Thanks @pkosanam. I still see an issue. The queries use transactionName = 'WebTransaction/Uri/club-manager/index.php'. This will not work for every customer and I assume this transaction name is specific to your PHP test application.

You might have to use something like WHERE transactionName like '%'. Please have a look at the original dashboard json to see how it worked before.

cc @raahulbasu

polfliet avatar Aug 23 '22 13:08 polfliet

Hey @pkosanam, looks like you have some conflicts with the dashboard on the main branch. This is most likely just do to the rollback of the last PR, pulling in the latest from main should get that cleared up!

aswanson-nr avatar Aug 29 '22 15:08 aswanson-nr