newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

NR-31202 C# integration

Open pkosanam opened this issue 2 years ago • 3 comments

Summary

Ticket URL: https://issues.newrelic.com/browse/NR-31202

Description: This PR has the new quickstart integration named "C#"

A concise description of the changes being introduced. If you are submitting a PR for a new quickstart please review the pre merge checklist section to validate this PR is ready for review.

Pre merge checklist

  • [ ] Did you check you NRQL syntax? - Does it work?
  • [ ] Did you check your dashboard image quality? - Do they look good?
  • [ ] Did you check that your alerts actually work?
  • [ ] Did you include an InstallPlan and Documentation reference?
  • [ ] Did you check your descriptive content for voice, tone, spelling and grammar errors?
  • [ ] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots

Attach images of any visual changes, such as a dashboard here.

Preview

c-sharp-preview

pkosanam avatar Aug 15 '22 02:08 pkosanam

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

github-actions[bot] avatar Aug 15 '22 02:08 github-actions[bot]

Hi @aswanson-nr ,

All checks on this PR are successful. But there is an issue while viewing the generated preview link.

On trying to view the preview link, the page redirects back to home page https://newrelic.com/instant-observability/

Link generated: https://newrelic.com/instant-observability/preview?local=true&quickstart=dotnet/c#

Screenshot: image

Could you please help me with this ?

Thank you. 😊

pkosanam avatar Aug 15 '22 02:08 pkosanam

Hey @pkosanam, I've had the terminal cut off the portion of the url that is being broken onto the second line there. Could you confirm that you're getting the whole URL for the preview? It will redirect to the main catalogue if anything is miss configured.

aswanson-nr avatar Aug 15 '22 15:08 aswanson-nr

Closing this PR as we have raised a new PR: https://github.com/newrelic/newrelic-quickstarts/pull/1357

pkosanam avatar Sep 14 '22 15:09 pkosanam