newrelic-quickstarts icon indicating copy to clipboard operation
newrelic-quickstarts copied to clipboard

Adding Snyk quickstart

Open harrykimpel opened this issue 2 years ago • 9 comments

Signed-off-by: Harry Kimpel [email protected]

Summary

Adding Snyk quickstart

Pre merge checklist

  • [x] Did you check you NRQL syntax? - Does it work?
  • [x] Did you check your dashboard image quality? - Do they look good?
  • [x] Did you check that your alerts actually work?
  • [x] Did you include an InstallPlan and Documentation reference?
  • [x] Did you check your descriptive content for voice, tone, spelling and grammar errors?
  • [x] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots

Attach images of any visual changes, such as a dashboard here. snyk

harrykimpel avatar Jul 26 '22 15:07 harrykimpel

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

github-actions[bot] avatar Jul 26 '22 15:07 github-actions[bot]

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

github-actions[bot] avatar Aug 11 '22 02:08 github-actions[bot]

Please re-open this PR

harrykimpel avatar Aug 17 '22 13:08 harrykimpel

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

pls. re-open

harrykimpel avatar Aug 17 '22 13:08 harrykimpel

Hey @harrykimpel! This is looking almost good to go, there are just a few minor things to clean up before merge.

  1. Could you remove the node_modules/.yarn-integrity and yarn.lock files from this PR?
  2. For this quickstart to be "installable" you'll need to create an install plan, I would recommend going with the link directive and setting the url to the same page as your documentation link. Here's a good example of an install plan with a link directive.

Hi @aswanson-nr, I've deleted the yarn files and created an install plan file as suggested. For now, the link to the docs points to my personal blog. This will hopefully be migrated to an official Snyk docs page soon.

harrykimpel avatar Aug 19 '22 17:08 harrykimpel

@aswanson-nr is there anything else for me to do here?

harrykimpel avatar Aug 24 '22 15:08 harrykimpel

happy Wednesday @harrykimpel! My apologies for the latency here. I've only just joined the team as Product Manager as of 2 weeks ago, and so I've been slowly catching up to everything. Please allow me to the end of the week to review and then I'll have a real response for you on this. Thank you for your continued patience

seemantk avatar Aug 24 '22 21:08 seemantk

happy Wednesday @harrykimpel! My apologies for the latency here. I've only just joined the team as Product Manager as of 2 weeks ago, and so I've been slowly catching up to everything. Please allow me to the end of the week to review and then I'll have a real response for you on this. Thank you for your continued patience

@seemantk no worries at all and congrats to you joining the team as PM. This is an exciting area to be in within New Relic. Just let me know if there is anything I can help with or any other feedback for such contributions.

harrykimpel avatar Aug 25 '22 08:08 harrykimpel

happy Wednesday @harrykimpel! My apologies for the latency here. I've only just joined the team as Product Manager as of 2 weeks ago, and so I've been slowly catching up to everything. Please allow me to the end of the week to review and then I'll have a real response for you on this. Thank you for your continued patience

@seemantk no worries at all and congrats to you joining the team as PM. This is an exciting area to be in within New Relic. Just let me know if there is anything I can help with or any other feedback for such contributions.

@harrykimpel thank you so much! It's very exciting to be part of New Relic! I've been chatting about your PR internally and I I just need to loop in someone so that we can move forward next week. Thank you for your continued patience and bearing with me.

seemantk avatar Aug 27 '22 06:08 seemantk

@harrykimpel thank you for your patience. we have some exciting product work underway that will make this integration easier, I'll love to reach out directly if you're open to that?

seemantk avatar Sep 01 '22 21:09 seemantk

@harrykimpel thank you for your patience. we have some exciting product work underway that will make this integration easier, I'll love to reach out directly if you're open to that?

@seemantk sounds interesting. happy to jump on a call to discuss directly.

harrykimpel avatar Sep 08 '22 05:09 harrykimpel

@harrykimpel thank you for your patience. we have some exciting product work underway that will make this integration easier, I'll love to reach out directly if you're open to that?

@seemantk sounds interesting. happy to jump on a call to discuss directly.

Excellent thank you @harrykimpel! What's the best way to connect with you? I can be e-reached via skulleen at newrelic

seemantk avatar Sep 08 '22 12:09 seemantk

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

github-actions[bot] avatar Sep 23 '22 02:09 github-actions[bot]

The PR checks have run and found the following warnings:

Warning Filepath Line #
"permissions" field should not be used dashboards/snyk/snyk.json 4

Reference the Contributing Docs for Dashboards for more information.

github-actions[bot] avatar Oct 19 '22 19:10 github-actions[bot]

The PR checks have run and found the following warnings:

Warning Filepath Line #
"permissions" field should not be used dashboards/snyk/snyk.json 4

Reference the Contributing Docs for Dashboards for more information.

github-actions[bot] avatar Oct 19 '22 19:10 github-actions[bot]

The PR checks have run and found the following warnings:

Warning Filepath Line #
"permissions" field should not be used dashboards/snyk/snyk.json 4

Reference the Contributing Docs for Dashboards for more information.

github-actions[bot] avatar Oct 19 '22 19:10 github-actions[bot]