newrelic-dotnet-agent icon indicating copy to clipboard operation
newrelic-dotnet-agent copied to clipboard

Support new Couchbase client.

Open vuqtran88 opened this issue 5 years ago • 2 comments

Feature Description

At the current state, the Agent instruments methods in the Couchbase.CouchbaseBucket class from the Couchbase.NetClient assembly. Starting from the version 2.5.0 and forward, the implementation of Couchbase.CouchbaseBucket has changed, which causes the Agent to miss instrumenting calls. Couchbase integration tests fail. Below are issues I found with different versions of Couchbase:

  • Starting from from ver 2.4.5, the call Task<IQueryResult<T>> QueryAsync<T>(string query) is duplicately instrumented.

  • Starting from the version 2.5.2, the Agent at least misses to instrument this IDocumentResult<T> Replace<T>(IDocument<T> document) call due to logic change. There are many more that the agent misses.

  • According to the up-to-date implementation of the Couchbase.CouchbaseBucket, there are no longer any method calls that the agent expects to instrument from this class.

A list of methods that the Agent is currently instrumenting for the Couchbase.CouchbaseBucket class is in this file. https://github.com/newrelic/newrelic-dotnet-agent/blob/main/src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/Couchbase/Instrumentation.xml

vuqtran88 avatar Oct 09 '20 00:10 vuqtran88

@vuqtran88 Thank you for submitting this issue. Could you add more details around what is not instrumented? This is so a contributor who sees this issue has more specific details. I would suggest explaining what you already know here.

angelatan2 avatar Oct 09 '20 15:10 angelatan2

@vuqtran88 Thank you for submitting this issue. Could you add more details around what is not instrumented? This is so a contributor who sees this issue has more specific details. I would suggest explaining what you already know here.

Updated.

vuqtran88 avatar Oct 09 '20 22:10 vuqtran88

https://issues.newrelic.com/browse/NEWRELIC-3506

Commented by svengala: This is not in our short term roadmap at this time based on usage. Please upvote if you find this feature useful. Thanks.

This issue won't be actioned.