newrelic-dotnet-agent icon indicating copy to clipboard operation
newrelic-dotnet-agent copied to clipboard

Refactor nested try/catch in ConnectionHandler

Open tippmar-nr opened this issue 5 months ago • 1 comments

Describe the story, please be clear on scope of the story.

There's a nested try/catch in SendDataOverWire() that can cause a misleading error message to be emitted indicating a serialization error that didn't really occur, because the nested try/catch throws the exception after logging it.

We need to refactor so that the call to _serializer.Serialize() is in a separate try/catch from the try/catch around wire.SendData(). This will eliminate the misleading message.

Acceptance Criteria

Error messages in SendDataOverWire() are not misleading

Estimates

Please provide initial t-shirt size S

tippmar-nr avatar Sep 19 '24 16:09 tippmar-nr