newrelic-dotnet-agent icon indicating copy to clipboard operation
newrelic-dotnet-agent copied to clipboard

Agent obfuscates commented data in SQL queries

Open rchekryzhov opened this issue 2 years ago • 2 comments
trafficstars

Description Agent obfuscates comments in SQL queries:

-- File: /build/source/Foo/Bar.cs:127
select id from bar 

turns into:

-- File: /build/source/Foo/Bar.cs:?
select id from bar 

Expected Behavior Commented SQL should not be obfuscated

For Maintainers Only or Hero Triaging this bug Suggested Priority (P1,P2,P3,P4,P5): Suggested T-Shirt size (S, M, L, XL, Unknown):

rchekryzhov avatar Aug 20 '23 22:08 rchekryzhov

https://issues.newrelic.com/browse/NR-152348

Hi @rchekryzhov thanks for letting us know about this. We currently don't have an specific log for handling comments in SQL queries, but nothing is really preventing us from doing so. We had a quick discussion as a team about this and there are some questions about potential sensitive information being put comments so we don't want to just not obfuscate them. Some exploration of different approaches is warranted to see what works best.

This makes this less of a bug and more of a feature request. I am going to get this setup as one so it can be reviewed.

jaffinito avatar Aug 22 '23 16:08 jaffinito