newrelic-client-go icon indicating copy to clipboard operation
newrelic-client-go copied to clipboard

(fix) made boolean omitempty values references

Open amaor-newrelic opened this issue 2 years ago • 2 comments

THIS IS A BREAKING CHANGE This PR addresses a number of issues with the API used to update channels and destinations

  1. It was impossible to update any boolean field from true to false
  2. Empty filter was not marshalled correctly Unfortunately, it was impossible to implement these changes in a backward-compatible way. The current API is just does not match our GraphQL API.

See this pr for reference

amaor-newrelic avatar Nov 08 '22 13:11 amaor-newrelic

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: NSSPKrishna
:white_check_mark: amaor-newrelic
:x: mbazhlekova
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 08 '22 14:11 CLAassistant

@amaor-newrelic Thank you for your contribution! Sorry for the delay on this. We're doing some feature work that we're hoping to get into v2 before releasing another major version since it's a bit of a hassle in Go. Happy to review once that work is finished.

mbazhlekova avatar Nov 21 '22 19:11 mbazhlekova