newrelic-cli icon indicating copy to clipboard operation
newrelic-cli copied to clipboard

[Feature] Terraform: add widget_type validation support for widget_log_table

Open nunopi opened this issue 2 years ago • 1 comments

Feature Description

Add "logger.log-table-widget" / "widget_log_table" to the WidgetTypes map

Describe Alternatives

No alternatives as far as I know

Additional context

The validation for widget types is missing the widget log table type and as such, when converting a dashboard that contains this widget type to a terraform file, it fails with the following error: FATAL unrecognized widget type "logger.log-table-widget"

Support for this widget type has been added recently to terraform-provider-newrelic here: https://github.com/newrelic/terraform-provider-newrelic/issues/1831

See proposed change here: https://github.com/nunopi/newrelic-cli/commit/f83fb89f41cf2bfb23e90b84bd5b17f0e921bcd7

nunopi avatar Jul 04 '22 11:07 nunopi

I think your change looks good @nunopi

Could you create a PR for it?

kidk avatar Jul 25 '22 09:07 kidk