go-agent icon indicating copy to clipboard operation
go-agent copied to clipboard
verified publisher icon newrelic

Add integration for github.com/redis/rueidis

Open ankon opened this issue 1 year ago • 3 comments

Summary

rueidis is a newer redis client for go, supporting streaming and automatic pipelining. In our testing we see improvements indeed, but right now there is no integration with the go-agent.

Desired Behaviour

Have a default integration, just like for go-redis/v{7,8,9}.

Possible Solution

We implemented this, and it seems to work reasonably well.

nrrueidis.go.txt

Before converting this into a full-blown PR and adding boilerplate: WDYT?

ankon avatar Nov 01 '24 10:11 ankon

Just seeing this now, let us get back to you after the holidays

iamemilio avatar Dec 18 '24 21:12 iamemilio

Would you mind just throwing it into a draft PR? Reviewing integrations takes us some time because we have educate ourselves on the tool, and then on the library, and then on the PR haha. Its much easier to interact with this through github though.

iamemilio avatar Jan 13 '25 21:01 iamemilio

@iamemilio sorry, missed the comment and then forgot all about it. Here's the PR: https://github.com/newrelic/go-agent/pull/1098

ankon avatar Oct 10 '25 19:10 ankon