entity-definitions
entity-definitions copied to clipboard
feat: add VSPHEREVM to HOST relationship
Relevant information
This PR introduced a relationship between VSPHEREVM
entities and HOST
entities which was requested by a customer.
The vCenter/vSphere setup setup can be complex and very different depending on the user needs, and depending on how hostnames are defined in the customer's vCenter, this relationship may or may not be suitable. This is the reason why an additional condition has been introduced: the relationship will be created only if the corresponding telemetry contains the attribute label.enableVMHostNameRelationship
.
The PR will remain as Draft, until clarifying some doubts:
- [x] ~Is
CONTAINS
the proper/expected relationship type? (To be clarified with the PM)~- Confirmed,
CONTAINS
is the expected relationship type.
- Confirmed,
- [x] ~The relationship definition uses a candidate relationship for HOST that already existed. Specifically HOST category. We need to clarify if the existing lookup with
matchingMode: FIRST
will work even if only one of the fields is present.~.- Since no uninstrumented entities are expected, we will probably need a different candidate.
- [x] ~If the the candidate relationship specified above worked, would its current definition suit the expectations? If no HOST entity is found an uninstrumented entity will be created. (To be clarified with the PM).~
- It doesn't suit the expectations, for this particular scenario no unistrumented entity should be created.
Checklist
- [x] I've read the guidelines and understand the acceptance criteria.
- [x] The value of the attribute marked as
identifier
will be unique and valid. - [x] I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.