entity-definitions icon indicating copy to clipboard operation
entity-definitions copied to clipboard

Fix: Creating relationship between otel entity and ElastiCache redis cluster

Open AravindKumar8520 opened this issue 10 months ago • 3 comments

Ticket -> https://new-relic.atlassian.net/browse/NR-259478

This PR is about creating candidate file for AWS_ELASTICACHE_REDIS_CLUSTER, to create the relationship between the Otel/APM and AWS_ELASTICACHE_REDIS_CLUSTER

  1. For this we have created a python test app with Otel provider
  2. Here is the doc link which explain the test app creation and metrics -> https://docs.google.com/document/d/1c54W-slYouCFpnjPe1cG-JGATHpTgKgkTjC4dVmKVps/edit
  3. Here is the metric table -> https://staging.onenr.io/0gR7nygYxwo

Checklist

  • [x] I've read the guidelines and understand the acceptance criteria.
  • [x] The value of the attribute marked as identifier will be unique and valid.
  • [x] I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

AravindKumar8520 avatar Apr 19 '24 10:04 AravindKumar8520

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 19 '24 10:04 CLAassistant

Also, I'd split relationships/synthesis/EXT-SERVICE-to-INFRA-ELASTICACHE-REDIS-CLUSTER in two and would move the rule for APM to a new relationships/synthesis/APM-APPLICATION-to-INFRA-ELASTICACHE-REDIS-CLUSTER file, so filenames are consistent with their content.

javimb avatar May 15 '24 08:05 javimb

By checking the regular expression we have modifed the regex regex: "^Datastore/instance/Redis/[^/].cache.amazonaws.com/[0-9]+" to "^Datastore/instance/Redis/[^/]\.cache\.amazonaws\.com/[0-9]+"

As we are unable to see the instrumented redis cluster in apm entity, this may not be the actual problem but as a best practice we have added \. after cache in the above regular expression

AravindKumar8520 avatar May 20 '24 16:05 AravindKumar8520