aws-log-ingestion icon indicating copy to clipboard operation
aws-log-ingestion copied to clipboard

Make nr_tags optional

Open adiesner opened this issue 2 years ago • 4 comments

The documentation states that the field nr_tags is optional. But the terraform code requires you to specify the field. Documentation: https://docs.newrelic.com/docs/logs/forward-logs/aws-lambda-sending-cloudwatch-logs/

Error without setting the nr_tags field:

➜ terraform plan
╷
│ Error: Missing required argument
│
│   on main.tf line 21, in module "newrelic_log_ingestion":
│   21: module "newrelic_log_ingestion" {
│
│ The argument "nr_tags" is required, but no definition was found.

This commit adds a default value, so that the field is actually optional as stated in the documentation.

adiesner avatar Jul 13 '22 07:07 adiesner

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 28 '23 20:04 CLAassistant

Hi @adiesner , do we know if this is getting merged anytime soon? You're right, this should be optional

jponc avatar Jul 10 '23 04:07 jponc

Hi @adiesner , do we know if this is getting merged anytime soon? You're right, this should be optional

Sadly I have no idea. I never heard anything back from them besides an automated email from the CLAassistant. I will get in touch with my contact at NewRelic and ask what is missing.

adiesner avatar Jul 10 '23 06:07 adiesner

@jcsobrino please merge this PR.

stevemao avatar Dec 13 '23 02:12 stevemao