newfrenchy83

fix https://github.com/project-ethea/After_the_Storm/issues/86

resolve https://github.com/wesnoth/wesnoth/issues/9035 issue by reply to @stevecotton suggestion.

Fix Weapon special filters can be affected by the weapon special leading to infinite recursion

19

When for example we have [damage_type][filter_self][has_attack|filter_weapon]type=pierce applied to one or any pierce type attack and the unit does not have an unaffected pierce attack, the change in type triggers an...

Doing [filter_attack/weapon]type= pick type who doing more damage only

3

Fix (https://github.com/wesnoth/wesnoth/issues/8585)

When for example we have [damage_type][filter_self][has_attack|filter_weapon]type=pierce applied to one or any pierce type attack and the unit does not have an unaffected pierce attack, the change in type triggers an...

move filter_abilitie/specials code in abilities.cpp

1

The code was moved to abilities.cpp so that it can be called from the units or attack_type functions, the attack_type function state necessary for the tags [filter_special_active] and [remove_specials] which...

remove 'experimental_' of filter_ability/specials tags

3

now what 1.18 separate of master branch it istime of aiming for that.

made tag_name is mandatory in [experimental_filter_ability(_active)] but remain optionnal in overwrite_specials[overwrite][experimental_filter_specials]

30

Fix https://github.com/wesnoth/wesnoth/issues/7992