newfrenchy83

[new feature 1.17] create a filter_distant for detect unit distant and test if enemy or not( more simple what filter_location)

27

use a "filter_distant" equivalent ot "filter_adjacent" is simplest to write and more dynamic what [filter_location] because is it no more necessary to specifie side of unit. More intessting for encode...

(1.17/1.18)remove deprecated backstab option

19

Backstab attribute option deprecated, we could remove that, isn't it?

add a [damage_type] special or ability who modify the type of attack used

16

At the suggestion of @stevecotton, I propose a special [damage_type] capable of modifying the type of attack used when the conditions are met. Its operation is similar to [attack_alignment]: https://github.com/wesnoth/wesnoth/pull/6968....

Add "attack_alignment" weapon special/ability for specific attacks

49

Although it is possible to mimic the operation of an alignment of the unit according to the time of day in standard conditions with [damage], the use of a fixed...

Add modification count and ids in formula(postpone 1.19)

21

Can resolve https://github.com/wesnoth/wesnoth/issues/8179 issue while waiting for the release of the use of the number of advancement or their identity to be decided, I added both in the formulas

Generalize the use of max_value and add the min_value attribute

11

In the case of [leadership], the fact that the values of each ability can be added when cumulative=yes can justify the addition of limit values not to be exceeded, but...

change calculation rules so that add and sub are always used independently

18

when two special weapons use multiply and divide with the same id, both operations are used, isn't that so why should it be different with 'add' and 'sub' where it's...

Add a 'special_id_active' attribute to [overwrite] in case the 'experimental_filter_specials' filter is not accepted(postpone 1.19)

2

Because of this risk I duplicate special_id_active in overwrite to be sure to maintain a way to remain selective on the abilities/specials to overwrite.

Remove one or more special weapons based on common stats and add 'filter_special' in [filter_weapon/attack/has_attack] filters

13

In [effect] you can add a special weapon or replace the existing specials with others, or specifically remove a weapon by the identifier but not by the tag_name or other...

add a attack 'alignment' attribute for have specific attack alignment different of unit alignment

25

it is almost same what https://github.com/wesnoth/wesnoth/pull/6968 who is rebased with this commit but i add only attribute in [attack] here