newfrenchy83

> So if an ability had `value=15` with `add=15` (sums to 30) and another ability of the same type had `value=20` with `add=5` (sums to 25), then it would use...

The calculation is done after the 'for' loop where highest value of each attribute are selected and after check of all list the calulation comp_val = value + add etc...

> Does this supercede #6968 then, or are both needed? Like i said, the commit of this pr is New base to https://github.com/wesnoth/wesnoth/pull/6968, it can be merged apart if idea...

i modified code for what if 'alignment' write with attack_alignment or unit_type alignment attribute don't matche with regular alignment then "neutral" value was returned for maintain coherent with actual logic

> > @knyghtmare given your comment at [#6968 (comment)](https://github.com/wesnoth/wesnoth/pull/6968#issuecomment-2101278325), do you have a preference one way or the other? > > I would suggest the simplest approach, adding in the...

> What is the difference between this PR #8851 and #6968 ? They seem to come off as kind of the same so want to know what's really happening. in...

> I don't think it makes sense to use the `attack_` prefix when no other attribute (besides `attack_weight` where it has a different meaning) uses it. If this is deemed...

> > i don't want whar wml develloper confuse alignment with attack_alignment when using [effect] > > You mean the confusion would be between > > ``` > [effect] >...

@soliton- The tests finally succeed, do you really want to change 'attack_alignment' to 'alignment'? I think keeping two different terms would be more readable for developers, 'alignment' in a filter...

@Pentarctagon simplified code by suggestion of @soliton-