newfrenchy83
newfrenchy83
> I've assumed that this is lower priority than the infinite recursion fixes. > > My main question is, why are there still some abilities that aren't using this code...
> I've assumed that this is lower priority than the infinite recursion fixes. > > My main question is, why are there still some abilities that aren't using this code...
> If almost all callers pass EFFECT_CLAMP_MIN_MAX, then it might as well be the default code path. Instead of changing the callers, I'd like that to be the default for...
> > in illuminates, this is highest "max_value" and lowest "min_value" who are used then what here it is lowes"max_value" and highest "min_value" > > Is there a reason for...
@stevecotton could you review thisPR and give your opinion when you would have the time?
> I'm not sure what we want to do with the 1.17 API, but I feel the current behavior in 1.16 is probably unexpected, and that we should add a...
> Can someone explain what exactly this PR is doing? It has to do with add and sub are used in the same ability? Or only if it's two different...
@Pentarctagon Given that when using both add and sub in an ability, only sub is considered, and since this PR allows their simultaneous use as one should intuitively expect, would...
> The simple part of the answer is, it's not getting merged for 1.18. > > However, the main answer, about when it became too late, is more complex. Although...
> As for cumulative, my understanding is that essentially only affects leadership, and for that I'd say that it should use the largest value after taking add and sub into...