newfrenchy83

Results 96 comments of newfrenchy83

Remove one or more special weapons based on common stats and add 'filter_special' in [filter_weapon/attack/has_attack] filters

i rebased for solve conflict with master, sorry.

Remove one or more special weapons based on common stats and add 'filter_special' in [filter_weapon/attack/has_attack] filters

@stevecotton could you review anew this PR now what 1.19 released(almost)?

Remove one or more special weapons based on common stats and add 'filter_special' in [filter_weapon/attack/has_attack] filters

> I'm against merging this as long as it adds two tags for no apparent reason. No apparent reason? And special_id and special_id_active, not reason to two filter different?

Remove one or more special weapons based on common stats and add 'filter_special' in [filter_weapon/attack/has_attack] filters

the 3first commit are same what https://github.com/wesnoth/wesnoth/pull/8546

Generalize the use of max_value and add the min_value attribute

> Why is there special handling for leadership and illuminates? Illuminates has already own code for max_value and min_value and i fear to modify that, and for leadership i replace...

Generalize the use of max_value and add the min_value attribute

> More generally, I would think that `max_value` and `min_value` should work the same for all abilities. the illuminated abilities affect both the beneficiary unit as well as the units...

Generalize the use of max_value and add the min_value attribute

> What I mean is that I'd expect they functionally work the same so that for any ability with a value attribute, the final value is restricted to the range...

Generalize the use of max_value and add the min_value attribute

> Alright. Can you rebase this against the current master branch? it's done, cheking begin.

Generalize the use of max_value and add the min_value attribute

@Pentarctagon check work perfectly except Windows

Generalize the use of max_value and add the min_value attribute

close this PR, review https://github.com/wesnoth/wesnoth/pull/8722, please.