Nevkontakte
Nevkontakte
I think emitting a custom event (option #1) is a reasonable solution here. In my opinion it has several advantages: - Both Go and external JavaScript code can receive such...
Yes, using ES 2015 Map type is likely the best solution, and I would venture a guess that it can improve performance overall. I see you already started prototyping in...
@tomconnell-wf I've looked through the diff and there is nothing obviously incorrect in it I could pin the test failure on. My best guess is that somewhere in the `reflect`...
I would strongly prefer not to do this, not for performance, but for maintenance reasons. A lot of our work on gopherjs over the past year has been dedicated to...
I haven't tested it, but I'm pretty sure this is the line you need to modify to make `reflect` work: https://github.com/gopherjs/gopherjs/blob/fa8544dfc7cb6b7b2e18dc7a67976e77e47b5efc/compiler/natives/src/reflect/reflect.go#L711 it probably should be something like `keys: js.InternalObject(m).Call("keys"),`. https://github.com/gopherjs/gopherjs/blob/fa8544dfc7cb6b7b2e18dc7a67976e77e47b5efc/compiler/natives/src/reflect/reflect.go#L757...
@tomconnell-wf no worries, and thanks for your work. This isn't an easy change, but it will be a valuable one. I will probably have some spare time this weekend, so...
@tomconnell-wf thanks for posting the test case, it made it very easy to reproduce and find the issue. I pushed the fix into your branch. The Go expression `len(m) ==...
I fixed a couple more bugs and all `reflect` tests are passing now. Hopefully the remaining few won't be too difficult to weed out.
I fixed a couple more bugs and all `reflect` tests are passing now. Hopefully the remaining few won't be too difficult to weed out.
I've tried to reproduce your issue at current master and I noticed an interesting behavior: ``` $ gopherjs build github.com/flimzy/timeconvertiontest $ gopherjs build github.com/flimzy/timeconvertiontest main.go:10:17: cannot convert time.Now() (value of...