jQuery-Mapael icon indicating copy to clipboard operation
jQuery-Mapael copied to clipboard

Which files need to be hosted

Open pvnr0082t opened this issue 8 years ago • 8 comments

Hi @neveldo , We are cdnjs team, we want to host this library in cdnjs. I'd like to confirm that if the js files under js/maps folder need to be hosted. Please help me check this. Thank you.

https://github.com/cdnjs/cdnjs/issues/9412

pvnr0082t avatar Oct 29 '16 03:10 pvnr0082t

Hi @pvnr0082t , i'm glad to see that jQuery Mapael will be hosted in cndjs.

The JS files under js/map folder are some maps available for Mapael. I see that for jqvmap library, cdnjs hosts all maps included within the project, so I think the maps from Mapael can be hosted too.

For your information, additional maps for Mapael can be found in this repository. Maybe it could be a good idea to host them too ? However, this repository is not tagged in any version, is it required for being hosted in cdnjs ?

Thanks !

neveldo avatar Oct 29 '16 22:10 neveldo

@neveldo Thanks for your help. @PeterDaveHello Should we also try to host https://github.com/neveldo/mapael-maps which contains additional maps for Mapael? Or open an issue to treat it as a new library?

pvnr0082t avatar Oct 30 '16 02:10 pvnr0082t

of course take them as two.

PeterDaveHello avatar Oct 30 '16 03:10 PeterDaveHello

Nice ! Does the repository that contains additional maps need to be versionned ?

neveldo avatar Oct 30 '16 10:10 neveldo

@neveldo yes, by git tag, thanks.

PeterDaveHello avatar Oct 30 '16 11:10 PeterDaveHello

I am glad my request to cdn is being handled. Thanks

Samjin avatar Oct 31 '16 00:10 Samjin

@Samjin You're are welcome :) @PeterDaveHello : here we go : mapael-maps 1.0.0

neveldo avatar Oct 31 '16 10:10 neveldo

@neveldo Thanks. I created a request for mapael-maps. https://github.com/cdnjs/cdnjs/issues/9447

pvnr0082t avatar Oct 31 '16 11:10 pvnr0082t