Dzmitry Neviadomski

Results 86 comments of Dzmitry Neviadomski

> Let's note for context that CPack 3.19 is from 2 years ago: [kitware.com/cmake-3-19-0-available-for-download](https://www.kitware.com/cmake-3-19-0-available-for-download/) (and we're at 3.24 now, very soon 3.25) There're some "legacy" systems we need to support,...

@ckerr I need some info here about how transmission is built for releases published on Travis and website. Is it `xcodebuild`? Maybe CMake/CPack? Should it be implemented for both? Thanks

> Having a wrapper just to tell you "please drag the app to /Applications" feels like an outdated practice to me. For instance, when you download Xcode, it's not given...

> With a dmg, you have to delete it manually afterwards, no? Yes, but that means nothing. We already distribute via DMG, I propose to make it nice.

@ckerr If you are ok with the idea, this is pretty much straightforward thing to do and may be labeled with "good first issue". Notes for anyone wanting to implement...

As a sidenote: Can't we add new command line option, which opens url with `xdg-open` on daemon launch? I think it would be appropriate to use this option with `.desktop`...

I tried `ENABLE_USER_SCRIPT_SANDBOXING` before, and this won't work as is, I think. 1. You need to declare shell script we call from build steps. 2. You need to declare everything...

> Should be good now with [f3c6099](https://github.com/transmission/transmission/commit/f3c6099ee126b07a7a625e62a30dfd601ca2592d) ? No, I don't think so. Please, take a look at https://github.com/transmission/transmission/blob/main/update-version-h.sh#L61-L81 This script reads `.git/` (indirectly, via invoking `git`) and reads+writes `REVISION`...

@Coeur Do you still want `ENABLE_USER_SCRIPT_SANDBOXING=YES` right now? :D I think this can be enabled later, when our Xcode build is fully out-of-tree and incremental.

You enabled sandboxing in project, but disabled it in specific (`libtransmission`) target, right? Also, `BuildIndependentTargetsInParallel` has been lost in the second commit, is it intentional?