Dzmitry Neviadomski

Results 120 comments of Dzmitry Neviadomski

> We only need to do a basic implementation (well, that covers the features of the existing QuickLook plugin), and other changes or additions can be done in later pull...

> Can the PR be reviewed in its current state or shall I wait for the final implementation? I think it can be reviewed already in this state. Maybe this...

> Overall solid work, just a few nits. > > I'll approve after I actually delve deep into the xib when I have time to clone the branch and build...

Rebase, Code review fixes, Removed my signing info.

@ckerr FYI, this PR is triggering `alpine` and `debian` actions. I think changes in `Transmission.xcodeproj` should be ignored for these runners.

@DevilDimon Can you help here? ``` /Users/teamcity/buildAgent1/work/1f3bff43dd55cfe9/macosx/QuickLookExtension/PreviewViewController.mm:12:9: fatal error: module 'QuickLookUI' not found @import QuickLookUI; ~~~~~~~^~~~~~~~~~~ ``` No problem locally, I think Xcode/SDK is outdated on teamcity agent.

@DevilDimon Can you help me here with creating CMake subproject for appex? I'm not really good with CMake packaging for macOS, sorry 😞

> This fixes many warnings when building with Xcode on Apple Silicon. Yup, I see these warnings a lot too. > 1. We could `GCC_GENERATE_DEBUGGING_SYMBOLS = NO`, but that would...

@Coeur I have just checked, it was enough to set `GENERATE_MASTER_OBJECT_FILE = YES` for `deflate` and `event` targets.