xrdp icon indicating copy to clipboard operation
xrdp copied to clipboard

Simplify allowed system calls for xrdp

Open matt335672 opened this issue 11 months ago • 1 comments

This PR relates to a comment I made on ccead296e615b92afc17daf67447876fb3c122e0

My original plan was to

  • Remove SystemCallErrorNumber= as this makes for safer deployments (although it's fine for development).
  • Investigate the reasons why we needed to add @system-service to SystemCallFilter=

The second one of these defeated me. Although I'd encountered the problem myself during GFX development, I was unable to generate it with the current devel release on my own test setups. Since we're close to releasing v0.10, I though it too risky to remove this setting now.

However, I did note from the output of systemd-analyze syscall-filter (Ubuntu 22.04) that this line can be simplified considerably.

$ systemd-analyze syscall-filter
   <snipped>
@system-service
    # General system service operations
    @aio
    @basic-io
    @chown
    @default
    @file-system
    @io-event
    @ipc
    @keyring
    @memlock
    @network-io
    @process
    @resources
    @setuid
    @signal
    @sync
    @timer
    capget
    capset
    copy_file_range
    fadvise64
    fadvise64_64
    flock
    get_mempolicy
    getcpu
    getpriority
    ioctl
    ioprio_get
    kcmp
    madvise
    mremap
    . . .
    setsid
    splice
    sysinfo
    tee
    umask
    uname
    userfaultfd
    vmsplice

I also tested the lists on CentOS 8 which contain the same items.

matt335672 avatar Mar 22 '24 12:03 matt335672

@Nexarian - can you look at this one before I back-port it to v0.10.x?

matt335672 avatar Mar 22 '24 12:03 matt335672

@metalefty - if you're going for a beta.3 with the improved CRC handling, I suggest we merge this.

matt335672 avatar Apr 11 '24 10:04 matt335672

Thanks, my time is quite limited for a while but I will ship this to beta.3.

BTW, CRC is xorgxrdp stuff and will be released separately.

metalefty avatar Apr 11 '24 15:04 metalefty

No issues here. Honestly I think the reason I added this was, in the future, Nvidia GFX needs it. And even then, it only happened on my Quadro workstation and not on anything else.

Nexarian avatar Apr 11 '24 16:04 Nexarian

Thanks both - I'll do some merging.

matt335672 avatar Apr 12 '24 09:04 matt335672