xrdp
xrdp copied to clipboard
neutrinolabs
Add XRDP support for config.d style xrdp.ini and sesman.ini
It would be really cool if XRDP add support for config.d style configuration of XRDP. This would allow additional package repositories to simply be a config script on top of the distro XRDP package.
For example: Lets say a user wanted to apply some special tweaks (in a Debian syntax):
> apt install -y xrdp
> apt install -y xrdp-mytweaks
The xrdp-mytweaks package would only have to be a small script:
> cp 01-mytweaks-xrdp.ini /etc/xrdp/xrdp.config.d/01-mytweaks-xrdp.ini
In this file it might simply read:
[Globals]
port=50000
tls_ciphers=HIGH
(or whatever)
Then at runtime the XRDP daemon would load xrdp.ini; then in order of lowest to highest precedence any files in /etc/xrdp/xrdp.config.d overwriting the daemon config.
And sesman would do the same for /etc/xrdp/sesman.config.d/
--
Ideas? Would you this proposal be helpful?
Sounds good. Lots of softwares doing like that. It is worth considering.
BTW, we usually spell xrdp in lowercase.
As a distro maintainer for Ubuntu, I would love to see this! We recently started generating Ubuntu Desktop preinstalled images for HyperV and had to script changes to the configuration specific to HyperV. I would love to just have an xrdp-hyperv package in Ubuntu which ships the overrides.
As a distro maintainer for Kali Linux, I must say I would also be very happy with this feature. We use the xrdp package from Debian, except that we have a different xrdp.ini, and we also have a program (kali-tweaks) that can modify xrdp.ini on behalf of user. It would make our life easier if the main xrdp.ini would load all the files in eg. /etc/xrdp/config.d/*.ini, then we can put our overrides there.
Currently @metalefty is looking at moving the config files to use TOML.
TOML doesn't support includes directly (and likely never will), but I can see no reason why this couldn't be implemented at application level. Getting the TOML migration done first is probably a good idea.
