neutrino icon indicating copy to clipboard operation
neutrino copied to clipboard

Published 20 hours ago • verified publisher icon neutrinojs

chore: Update dependency webpack to v5

Open Nic128 opened this issue 3 years ago • 10 comments

https://github.com/neutrinojs/neutrino/issues/1624

Let's try webpack 5 again, at this point every plugin/loader have compatibility. This PR contains the content from these two branches.

  • https://github.com/neutrinojs/neutrino/pull/1584
  • https://github.com/neutrinojs/neutrino/compare/webpack-5

TODO:

  • [x] Infinite polling loop fix in webpack (HMR with node) https://github.com/webpack/webpack/pull/13877
  • [x] webpack-dev-server 4 https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md
  • [x] Webpack-chain v7 https://github.com/neutrinojs/webpack-chain/pull/297/ (Or use @gem-mine/webpack-chain, which has the PR content)
  • [x] Karma-loader to v5 (Problem with shimming assert and process)
  • [x] [webpack-cli] Error: [VueLoaderPlugin Error] No matching use for vue-loader is found.

Alternative, we could release v10 alpha. One step in the v10 milestone, figure it out as we go. https://github.com/neutrinojs/neutrino/milestone/7

Nic128 avatar Jul 12 '21 21:07 Nic128

Hi! Thank you for the PR.

In order to move this forwards:

  1. CI on this repo needs migrating away from Travis CI (since there are no credits left) - there is a WIP in #1663 but it has stalled
  2. webpack-chain needs webpack 5 support first

edmorley avatar Sep 08 '21 10:09 edmorley

Ported the CI changes from https://github.com/neutrinojs/neutrino/pull/1663.

Nic128 avatar Sep 09 '21 13:09 Nic128

Ported the CI changes from #1663.

Thank you for looking at the CI changes. Could you move them to their own PR? I'm a fan of keeping PRs to be about one change at a time, and this PR is already pretty large (+1,104 −1,304) :-)

edmorley avatar Sep 09 '21 14:09 edmorley

Created a new PR with just the CI changes. https://github.com/neutrinojs/neutrino/pull/1675

Nic128 avatar Sep 09 '21 14:09 Nic128

It's possible some of the compilation problem I'm having will be solved when webpack-chain gets the webpack 5 support.

Nic128 avatar Sep 09 '21 18:09 Nic128

The VueLoaderPlugin problem is eluding me. I'll need help. Hopefully, when upgrading webpack-chain, it'll resolve itself.

Edit: Upgrading webpack-chain is not the problem.

Nic128 avatar Sep 10 '21 15:09 Nic128

Got passed the vue-loader problem.

Nic128 avatar Oct 04 '21 15:10 Nic128

@edmorley The pipeline is now green, please review.

Nic128 avatar Oct 04 '21 15:10 Nic128

@Nic128 Sorry for the delay - busy + I don't use this project any more.

As mentioned in https://github.com/neutrinojs/neutrino/pull/1674#issuecomment-915110055 a pre-requesite for adding support for webpack 5 to Neutrino, is for webpack-chain to support webpack 5 first.

That work is being tracked here (help needed, since I won't be working on it): https://github.com/neutrinojs/webpack-chain/milestone/1

Many thanks!

edmorley avatar Oct 13 '21 09:10 edmorley

I have forked/published this branch for my own private usage and found bugs along the way. I'll update this PR when I find them.

Nic128 avatar Oct 28 '21 12:10 Nic128

Closing since unfortunately this project is no longer maintained. See: https://github.com/neutrinojs/neutrino/issues/1707 https://github.com/neutrinojs/webpack-chain/issues/358

edmorley avatar Feb 03 '24 19:02 edmorley