neutrino icon indicating copy to clipboard operation
neutrino copied to clipboard

Switch from eslint-loader to eslint-webpack-plugin

Open edmorley opened this issue 3 years ago • 3 comments

Recent Travis runs are showing:

npm WARN deprecated [email protected]: This loader has been deprecated. Please use eslint-webpack-plugin

It appears that eslint-loader has been deprecated in favour of eslint-webpack-plugin: https://github.com/webpack-contrib/eslint-loader#warning-deprecated https://github.com/webpack-contrib/eslint-webpack-plugin

Sounds like we should switch in Neutrino 10.

edmorley avatar Oct 12 '20 09:10 edmorley

I would assign this to myself with a pleasure.

Actually it doesn't require upgrading major version as there no actions from consumer side required. Am I right?

constgen avatar Oct 12 '20 10:10 constgen

Users could be passing custom options into the loader (via .neutrinorc.js customisation), and the new plugin supports different options. As such it's unfortunately a breaking change.

edmorley avatar Oct 12 '20 11:10 edmorley

You convinced me

constgen avatar Oct 12 '20 20:10 constgen