Clément Robert

Results 1705 comments of Clément Robert

I am very confused by the type checking error. It hardly seems related to anything we're doing here. What seems to be happening is that we're running mypy, targeting Python...

Before we do anything else, I suggest upgrading mypy, hoping that the issue (that I'm assuming is internal to mypy) was resolved already. I'm working on this in #4139

Hi @nitnyadv, thanks for reporting this ! I'll have a look and see if I can locate the problem here, but could you also throw in your param file (`amrvac.par`)...

Annotating grids with ```python slc.annotate_grids() ``` I obtain ![grid](https://user-images.githubusercontent.com/14075922/146529206-fb79f282-d5d4-4f92-8209-15ef8a036128.png) Is the grid properly represented ? Just checking

Thank you ! The convert type shouldn't be a problem, I don't expect we'll need it. Could you also show how you produced the "expected" reference image ?

I've verified that the bug isn't specific to the dev branch where you discovered it. The problem also exists in yt 4.0.1 (latest release to date), so it's not due...

> Actually, this is the two fluid version of AMRVAC so m_c1 corresponds to m1, p_c corresponds to p in the public version of AMRVAC. This version is still under...

> So, I'm glad that fixes it, but it isn't a great solution, right? I think we should adjust this somehow on the yt side. +1

for reference (and possibly as a starting point) https://github.com/yt-project/yt/pull/2945 fixed a similar issue, if I recall

it's not working out of the box for win32 + CPython 3.11 I'll follow numpy's similar patch for now https://github.com/numpy/numpy/pull/22102