neutralinojs-cli icon indicating copy to clipboard operation
neutralinojs-cli copied to clipboard

Fix/resource busy rmdir

Open viralgupta opened this issue 9 months ago • 2 comments

fixed Error: EBUSY: resource busy or locked, rmdir '../node' error while creating a neu app on Windows. This would leave a folder without removing the .tmp files from the folder.

Previous error image

Current Solution image

viralgupta avatar May 04 '24 16:05 viralgupta

Hello @viralgupta Thanks so much for sending this pull request :) Could you please let us know how to reproduce this issue?

Thanks :tada:

shalithasuranga avatar May 06 '24 11:05 shalithasuranga

Hi @shalithasuranga , this issue would occur if the default branch were something other than "main," in my case, it was the "master" branch for the "viralgupta/node-neutralinojs-template" template. I had renamed the branch after seeing this issue. So, to reproduce the issue, I have changed it back to the "master" branch for now.

so you can just run this to reproduce the bug neu create testapp -t viralgupta/node-neutralinojs-template

  • I have ran into this issue on windows, I think this problem don't appear in UNIX based Os's.

ps:

  • should we ask the user if he wants to clone the main branch or a different branch of the repo, because there is no way for the user to create the app using the neu create command if the default branch name is other than "main" since "main" branch is hardcoded in constants.
  • we can use this API to list the branches of a github repo

viralgupta avatar May 06 '24 13:05 viralgupta

Closing this issue since it doesn't occur with most templates and there are no issues similar reported by other developers. Thanks so much :tada:

shalithasuranga avatar Feb 15 '25 06:02 shalithasuranga