NiMARE icon indicating copy to clipboard operation
NiMARE copied to clipboard

Add correction for multiple contrasts within a study in Stouffer's IBMA

Open JulioAPeraza opened this issue 1 year ago • 2 comments

Closes None.

Changes proposed in this pull request:

  • Add the correction for multiple contrasts within a study in Stouffer's IBMA, implemented in https://github.com/neurostuff/PyMARE/pull/117

JulioAPeraza avatar Apr 19 '24 22:04 JulioAPeraza

if you merge in main, that should fix the codecov errors you are seeing!

jdkent avatar May 06 '24 19:05 jdkent

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (ac9792d) to head (e4ce01e). Report is 16 commits behind head on main.

Files Patch % Lines
nimare/meta/ibma.py 72.72% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   88.22%   88.15%   -0.07%     
==========================================
  Files          48       48              
  Lines        6352     6367      +15     
==========================================
+ Hits         5604     5613       +9     
- Misses        748      754       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 20:05 codecov[bot]

That's a good point. I tried to pass a 1D array since the groups and weights are the same across voxels, but PyMARE didn't allow that. In the end, we only use the information from one voxel: https://github.com/neurostuff/PyMARE/blob/master/pymare/estimators/combination.py#L145-L146

JulioAPeraza avatar May 22 '24 17:05 JulioAPeraza