NeuroKit icon indicating copy to clipboard operation
NeuroKit copied to clipboard

[BUG] Added detected rpeaks to ecg_process

Open rostro36 opened this issue 1 year ago • 1 comments

Description

This PR fixes #602 . It makes such that the detected RPeaks get added to ecg_quality.

Runs in docs/examples/bio_custom/bio_custom.ipynb. May have to adapt tests.

Proposed Changes

  • rpeaks["ECG_R_Peaks"] is used instead of None for ecq_quality.
  • Some automatic formatting

Checklist

  • [x] I have read the CONTRIBUTING file.
  • [x] My PR is targetted at the dev branch (and not towards the master branch).
  • [x] I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • [ ] I have added the newly added features to News.rst (if applicable)

rostro36 avatar Aug 10 '22 15:08 rostro36

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

welcome[bot] avatar Aug 10 '22 15:08 welcome[bot]

Good catch! will merge once it passes the checks

DominiqueMakowski avatar Aug 18 '22 02:08 DominiqueMakowski