NeuroKit icon indicating copy to clipboard operation
NeuroKit copied to clipboard

MNE 1.0: adjustments

Open DominiqueMakowski opened this issue 2 years ago • 1 comments

import neurokit2 as nk
import mne

raw = mne.io.read_raw_fif(
        mne.datasets.sample.data_path() + "/MEG/sample/sample_audvis_raw.fif", preload=True
    )
x = nk.mne_channel_extract(raw, what="EOG", name="EOG")
x

This used to return a vector (I think?), but now it returns a series (at least based on the bug in the test that caught this)

TODO: need to investigate mne_channel_extract() and see if changes are to be made based on the most recent MNE update

DominiqueMakowski avatar Mar 23 '22 14:03 DominiqueMakowski

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Sep 20 '22 19:09 stale[bot]

Hi, is this still an issue, I could take a look 😃

JoseAlanis avatar Oct 10 '22 19:10 JoseAlanis

I "think" it has been solved? since we don't have tests failing at least... But if they are other MNE-related things (and there will be, as enhancing the M/EEG aspect of NK is one of the goals), I'll let you know :)

btw, great job on the MNE-LIMO toolbox

DominiqueMakowski avatar Oct 11 '22 01:10 DominiqueMakowski