nrn icon indicating copy to clipboard operation
nrn copied to clipboard

Make notebooks work with `bokeh>=3` and remove `bokeh<3` pin

Open kbvw opened this issue 1 year ago • 15 comments

kbvw avatar Aug 28 '24 06:08 kbvw

✔️ 038ac6127b58ae104c439139f962b59054564b36 -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 28 '24 07:08 azure-pipelines[bot]

For some reason this seems to work locally but it fails in the CI. I'm looking into it.

EDIT: The error was actually from the other notebook, and with jupyter nbconvert --debug the output was so huge that I didn't spot that. It works fine.

kbvw avatar Aug 29 '24 08:08 kbvw

✔️ 827637e8449014aef43372156005f50d51e17986 -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 29 '24 08:08 azure-pipelines[bot]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (a2b8b35) to head (2d8ba03). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
share/lib/python/neuron/__init__.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files         572      572           
  Lines      106659   106664    +5     
=======================================
+ Hits        71351    71356    +5     
  Misses      35308    35308           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 09:08 codecov[bot]

Also unpinned numpy<2 in docs_requirements.txt as this was the only thing left blocking that.

kbvw avatar Aug 29 '24 15:08 kbvw

✔️ b548c9643d078585a8b6115d2d60729286dc119e -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 29 '24 15:08 azure-pipelines[bot]

✔️ e7b80ee7796b1e602420e0b9dcc8e0c19b275530 -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 29 '24 15:08 azure-pipelines[bot]

✔️ 09a154a7c46c0d54be44bb6355263f6eefea7fb3 -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 29 '24 17:08 azure-pipelines[bot]

✔️ e89d97b28402a89db286ecac9730e7544b0e1a75 -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 29 '24 19:08 azure-pipelines[bot]

✔️ e89d97b28402a89db286ecac9730e7544b0e1a75 -> Azure artifacts URL

azure-pipelines[bot] avatar Aug 30 '24 12:08 azure-pipelines[bot]

✔️ e89d97b28402a89db286ecac9730e7544b0e1a75 -> Azure artifacts URL

azure-pipelines[bot] avatar Sep 02 '24 12:09 azure-pipelines[bot]

✔️ a4e1f339841aa58fa365bb1d617611da950d6015 -> Azure artifacts URL

azure-pipelines[bot] avatar Oct 01 '24 12:10 azure-pipelines[bot]

✔️ 2d8ba038766d847b337dc43363a310c2356e0c16 -> Azure artifacts URL

azure-pipelines[bot] avatar Oct 02 '24 16:10 azure-pipelines[bot]