Make MutexPool an allocator
Move structpool.h to utils/pool.hpp
Move nrncvode/pool.h in utils/mutexed_pool.hpp.
The new pools is neuron-agnostic (hoc, ...).
To create a normal pool: Pool<int>
To create a pool protected with mutex: MutexedPool<int>, the type of the mutex can be given as a second optional argument (by default std::mutex) MutexedPool<int, std::recursive_mutex>
To follow https://en.cppreference.com/w/cpp/named_req/Allocator:
- Rename
alloctoallocate - Rename
hpfreetodeallocate
The function to clean the data has to be set with set_function it lets us, use a different name, a lambda, a free function, ... compare to before where the function should be part of the type and named clear().
Logfiles from GitLab pipeline #197596 (:no_entry:) have been uploaded here!
Status and direct links:
- :no_entry: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :no_entry: test:neuron:nmodl:intel:legacy
- :no_entry: test:neuron:nmodl:intel:shared
- :no_entry: test:neuron:nmodl:nvhpc:acc:legacy
- :no_entry: test:neuron:nmodl:nvhpc:acc:shared
- :no_entry: test:neuron:nmodl:nvhpc:omp:legacy
- :no_entry: test:neuron:nmodl:nvhpc:omp
Logfiles from GitLab pipeline #197935 (:no_entry:) have been uploaded here!
Status and direct links:
- :no_entry: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :no_entry: build:neuron:nmodl:intel:legacy
- :no_entry: build:neuron:nmodl:intel:shared
- :no_entry: build:neuron:nmodl:nvhpc:acc:legacy
- :no_entry: build:neuron:nmodl:nvhpc:acc:shared
- :no_entry: build:neuron:nmodl:nvhpc:omp:legacy
- :no_entry: build:neuron:nmodl:nvhpc:omp
- :fast_forward: test:neuron:nmodl:intel:legacy
- :fast_forward: test:neuron:nmodl:intel:shared
- :fast_forward: test:neuron:nmodl:nvhpc:acc:legacy
- :fast_forward: test:neuron:nmodl:nvhpc:acc:shared
- :fast_forward: test:neuron:nmodl:nvhpc:omp:legacy
- :fast_forward: test:neuron:nmodl:nvhpc:omp
✔️ d72251f281ba307b70c79bfc804ae8f219c10f77 -> Azure artifacts URL
Codecov Report
Attention: Patch coverage is 89.18919% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 67.14%. Comparing base (
2b928ad) to head (cc18266). Report is 1 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| src/utils/pool.hpp | 80.95% | 8 Missing :warning: |
| src/nrncvode/tqueue.cpp | 87.50% | 1 Missing :warning: |
| src/nrniv/cxprop.cpp | 75.00% | 1 Missing :warning: |
| src/nrniv/multisend.cpp | 80.00% | 1 Missing :warning: |
| src/utils/mutexed_pool.hpp | 97.61% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
- Coverage 67.15% 67.14% -0.01%
==========================================
Files 562 561 -1
Lines 104118 104073 -45
==========================================
- Hits 69923 69885 -38
+ Misses 34195 34188 -7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Logfiles from GitLab pipeline #200878 (:white_check_mark:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
✔️ 4a12b5776fc274bd68cae082c536bebc2d30e829 -> Azure artifacts URL
Logfiles from GitLab pipeline #201565 (:no_entry:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :no_entry: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
Logfiles from GitLab pipeline #202190 (:white_check_mark:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
✔️ 2b1719ad36aa1137ab71f3aacc4da306dcef6395 -> Azure artifacts URL
Logfiles from GitLab pipeline #202333 (:no_entry:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :no_entry: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :no_entry: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :fast_forward: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :fast_forward: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
✔️ 0936befd55a495d3b5c17451937d12d1d57bd704 -> Azure artifacts URL
Logfiles from GitLab pipeline #202367 (:no_entry:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :no_entry: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
Quality Gate passed
Issues
14 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
21.2% Duplication on New Code
✔️ cc1826600de5f222ce828710f62f6086a1405ee8 -> Azure artifacts URL
Logfiles from GitLab pipeline #204586 (:white_check_mark:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp