nrn
nrn copied to clipboard
Removal of nrncore_callbacks after CoreNEURON repo merge
When NEURON and CoreNEURON were separate repos, we needed callbacks / function-pointer mechanism between NEURON and CoreNEURON: See
- https://github.com/neuronsimulator/nrn/blob/d2a76abcdc5f8b8a1a687a52f350e0255d1bd817/src/nrniv/nrncore_write/callbacks/nrncore_callbacks.h
- Especially https://github.com/neuronsimulator/nrn/blob/d2a76abcdc5f8b8a1a687a52f350e0255d1bd817/src/nrniv/nrncore_write/callbacks/nrncore_callbacks.h#L195
- https://github.com/neuronsimulator/nrn/blob/d2a76abcdc5f8b8a1a687a52f350e0255d1bd817/src/nrniv/nrncore_write/callbacks/nrncore_callbacks.cpp#L34
With NEURON and CoreNEURON in the same repo, I think all the function-pointers related logic could be removed?
That is certainly the case if it's done at link time. And no need not to link the .o files into libnrniv.so . Certainly coming when the full integration into NEURON starts. If the wheels have -DNRN_ENABLE_CORENEURON=ON, it seems like this could be done earlier rather than later. What is the extra memory footprint?