nrn icon indicating copy to clipboard operation
nrn copied to clipboard

Add `multisend` testing

Open alexsavulescu opened this issue 3 years ago • 1 comments

Overview of the feature

The main idea is to add multisend coverage. Therefore we have a few aspects to be considered:

  • Would adding tqperf testing increase overall coverage and not just multisend ?
  • Otherwise could we just create a shorter test script and focus on multisend coverage?

Foreseeable Impact

  • Area(s) of change: CMake
  • Dependencies:
    • wait for merge: #1348
    • probably need to tackle before: #1346

alexsavulescu avatar Aug 03 '21 12:08 alexsavulescu

A great deal of tqperf is for performance measurement and BGP specific features. I think the coverage is more or less limited to multisend. A greatly reduced test seems reasonable. Results of multisend with all combinations of 1 or 2 phase and 1 or 2 subintervals should be identical to default allgather.

nrnhines avatar Aug 03 '21 13:08 nrnhines

I believe this is covered via https://github.com/neuronsimulator/tqperf/blob/master/test1.py (https://github.com/neuronsimulator/nrn/blob/master/test/external/tqperf/CMakeLists.txt) , however it is run only when CoreNEURON is enabled. @nrnhines do you think it's worth having a new test in nrn ?

alexsavulescu avatar Jan 11 '23 09:01 alexsavulescu

I think tqperf does the basic testing fairly well. However, the information in nrn/src/nrniv/netpar.cpp in regard to xchng_meth needs to be incorporated in the documentation for ParallleContext.spike_exchange along with a searchable topic named multisend

nrnhines avatar Jan 11 '23 13:01 nrnhines

However, the information in nrn/src/nrniv/netpar.cpp in regard to xchng_meth needs to be incorporated in the documentation for ParallleContext.spike_exchange along with a searchable topic named multisend

therefore to be more specific wrt this PR : https://github.com/neuronsimulator/nrn/pull/2144/files#diff-2270e014e25ab3684d417a94b4a8805b1dd03c4d7e3c1d75e17ada1e2019219d

alexsavulescu avatar Jan 11 '23 13:01 alexsavulescu

Sorry. Forgot about that.

nrnhines avatar Jan 11 '23 13:01 nrnhines

I've updated #2144 accordingly. Closing this ticket as testing implemented.

alexsavulescu avatar Jan 13 '23 09:01 alexsavulescu