py_neuromodulation
py_neuromodulation copied to clipboard
Minor changes on top of mne_lsl merge
Hi @timonmerk, I made some changes on top of the recent LSL merge. Summary:
- Remove settings parameter from LSLOfflinePlayer since it's not used, as the sampling frequency is passed in another parameter
- Defer LSLStream imports
- Fix a typing error
- Remove a couple variables
- Changed a couple errors for warnings:
- If both a filename and a data array was passed to LSLOfflinePlayer, it would throw an error. I changed it to a warning and defaulted to using the file as data source.
- If _GenericStream was reading from an LSLStream with different frequency that the one that was passed it would throw an Exception, instead I think we can warn the user and default to the LSLStream frequency.
It's in general problematic to have 2 sources of truth like in the case of GenericStream getting an sfreq value from the user and one from the stream. It's also quite annoying that Python does not support overloaded constructors like C++. Maybe when I'm done with the Settings I will also incorporate Pydantic into the stream classes to handle this better.